Allow collection-backed annotation array values in regression test#3023
Allow collection-backed annotation array values in regression test#3023Yong-yuan-X wants to merge 2 commits into
Conversation
|
Hey @Yong-yuan-X, thank you for another PR. We may have to rethink this a bit. It occurred to me that it's possibly better to treat this defect as a documentation bug. So instead of fixing all occurrences of Thus, I think this PR should update the test you made earlier to allow for the In the meantime, I will write up a better design in #3008 and if you still want to implement it we can discuss further there. Again, thank you for the contribution and apologies for changing the goal midway through the work. I hope you understand! :) |
f2ac2a1 to
df3ba04
Compare
|
@jaschdoc Thank you for the clarification, and no worries about the change in direction. I appreciate the explanation and will adjust the PR accordingly. I understand the concern that this is more about documenting the currently supported value shapes for I'll update this PR to narrow the scope:
I'll also follow the design update in #3008, and I'm happy to help with the future |
jaschdoc
left a comment
There was a problem hiding this comment.
Thank you for the PR! Feel free to open another one that fixes the documentation. Cheers :)
jaschdoc
left a comment
There was a problem hiding this comment.
Ah apologies for changing my mind. Just a nitpick that I wanted to catch first.
df3ba04 to
da137a5
Compare
|
I moved |
jaschdoc
left a comment
There was a problem hiding this comment.
Great, thank you for the changes.
Refs #3008
Summary
annotationArrayValueTyperegression test to document the currently supported value shapes for array-valued annotation arguments.Array<*>orCollection<*>.runTest.Tests
.\gradlew.bat :kotlin-analysis-api:test --tests "com.google.devtools.ksp.test.AAConfiguredUnitTestSuite.testAnnotationArrayValueType" --tests "com.google.devtools.ksp.test.PsiConfiguredUnitTestSuite.testAnnotationArrayValueType"AAConfiguredUnitTestSuite > testAnnotationArrayValueType() PASSEDPsiConfiguredUnitTestSuite > testAnnotationArrayValueType() PASSEDBUILD SUCCESSFUL